[PATCH] D37018: [GISel]: Legalize G_PHIs
Aditya Nandakumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 24 12:51:36 PDT 2017
aditya_nandakumar marked 2 inline comments as done.
aditya_nandakumar added a comment.
I see that the test cases I thought I updated (and added) are not there (and can't find them in my tree). I'll recreate them and add them to the review again.
================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:353
+ TargetOpcode::G_SEXT == ExtOpc) &&
+ "Expecting Extending Opc");
assert(MRI->getType(Res).isScalar() || MRI->getType(Res).isVector());
----------------
qcolombet wrote:
> Formatting looks weird. Is this clang-formatted?
Yup. This is clang-formatted..
https://reviews.llvm.org/D37018
More information about the llvm-commits
mailing list