[PATCH] D36990: [GISel]: Translate phi into generic G_PHI instruction

Aditya Nandakumar via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 15:39:30 PDT 2017


Hi Victor,

I pushed a fix for it shortly after (r311609).

Thanks
Aditya

> On Aug 23, 2017, at 3:25 PM, Victor Leschuk <vleschuk at accesssoftek.com> wrote:
> 
> Hello Aditya,
> 
> It looks like your commit has broken one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast>
> Failing Tests (1):
>     LLVM :: Verifier/test_g_phi.mir
> Could you please take a look at it?
> 
> On 08/22/2017 02:41 AM, Aditya Nandakumar via Phabricator via llvm-commits wrote:
>> aditya_nandakumar created this revision.
>> Herald added a subscriber: javed.absar.
>> 
>> Translate phi instructions into generic G_PHI instructions.
>> This has the same semantic as PHI but has types for operands.
>> This lets us verify that the G_PHI has compatible types for all operands.
>> This also allows specifying legalization actions for weird PHI types.
>> 
>> 
>> Repository:
>>   rL LLVM
>> 
>> https://reviews.llvm.org/D36990 <https://reviews.llvm.org/D36990>
>> 
>> Files:
>>   include/llvm/CodeGen/MachineInstr.h
>>   include/llvm/Target/GenericOpcodes.td
>>   include/llvm/Target/TargetOpcodes.def
>>   lib/CodeGen/GlobalISel/IRTranslator.cpp
>>   lib/CodeGen/MachineVerifier.cpp
>>   lib/Target/AArch64/AArch64InstructionSelector.cpp
>>   lib/Target/AArch64/AArch64LegalizerInfo.cpp
>>   lib/Target/AArch64/AArch64RegisterBankInfo.cpp
>>   test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
>>   test/CodeGen/AArch64/GlobalISel/select-phi.mir
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 
> -- 
> Best Regards,
> 
> Victor Leschuk | Software Engineer |Access Softek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/d13eb8fb/attachment-0001.html>


More information about the llvm-commits mailing list