[PATCH] D37064: [InstCombine] Fold insert sequence if first ins has multiple users.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added inline comments.


================
Comment at: test/Transforms/InstCombine/broadcast.ll:63
+  %a1 = fadd <4 x float> %ins1, %ins1
+  %ins2 = insertelement<4 x float> %ins1, float %v, i32 1
+  %ins3 = insertelement<4 x float> %ins2, float %v, i32 2
----------------
Hi Florian,
this looks good to me too, but shouldn't you also check that the transformation is not happening if any of the lanes of %ins1, other than the first one, is not an undef? Or is this case covered somewhere else?

Francesco


https://reviews.llvm.org/D37064