[PATCH] D37081: [TargetParser][AArch64] Add support for RDM feature in the target parser.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 24 00:19:35 PDT 2017


samparker added a comment.

Hi Chad,

Just a couple of small test suggestions from me.

thanks,
sam



================
Comment at: unittests/Support/TargetParserTest.cpp:816
                         AArch64::AEK_FP16 | AArch64::AEK_PROFILE |
                         AArch64::AEK_RAS | AArch64::AEK_SVE |
                         AArch64::AEK_DOTPROD | AArch64::AEK_RCPC;
----------------
Would be good to add the feature here.


================
Comment at: unittests/Support/TargetParserTest.cpp:845
                               {"profile", "noprofile", "+spe", "-spe"},
                               {"ras", "noras", "+ras", "-ras"},
                               {"sve", "nosve", "+sve", "-sve"},
----------------
and here.


https://reviews.llvm.org/D37081





More information about the llvm-commits mailing list