[PATCH] D37083: LNT Make machine selection/update more flexible

[Matthias Braun via Phabricator via llvm-commits]

MatzeB created this revision.
Herald added a subscriber: mcrosier.

Note: This patch is in response to the discussion in https://reviews.llvm.org/D35598. It allows to choose between different behaviors on mismatching machine information including the previous behavior of creating a new machine with the same name. My original plan was to always enforce unique machine names and append number suffixes in the duplication/splitting case. But it turns out this was extremely hard to implement correctly while support concurrent accesses, so I went with the previous solution instead where we can have multiple machines with the same name but different ids.

r309247 changed LNTs response to mismatching machine information to
either reject the submission or update the existing machine data. Some
users prefer the previous behavior of creating a separate machine with
the same name instead.

This changes LNT interface to accept an select-machine parameter:

- match: Rejects submission with mismatching machine information
- update: Updates the existing machine on mismatching machine information.
- split: Creates a new machine with the same name (but different id number) when none of the existing ones match the machine information.


Repository:
  rL LLVM

https://reviews.llvm.org/D37083

Files:
  lnt/lnttool/admin.py
  lnt/lnttool/common.py
  lnt/lnttool/import_data.py
  lnt/lnttool/main.py
  lnt/lnttool/viewcomparison.py
  lnt/server/db/testsuitedb.py
  lnt/server/ui/api.py
  lnt/server/ui/templates/submit_run.html
  lnt/server/ui/views.py
  lnt/tests/builtintest.py
  lnt/util/ImportData.py
  lnt/util/ServerUtil.py
  tests/lnttool/Inputs/compile_submission_machine_diff_split.json
  tests/lnttool/submit.shtest
  tests/server/db/search.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37083.112468.patch
Type: text/x-patch
Size: 26380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/ee91226f/attachment.bin>