[PATCH] D36335: Add ‘llvm.experimental.constrained.fma‘ Intrinsic

Wed Aug 23 12:12:19 PDT 2017

wdng added a comment.

In https://reviews.llvm.org/D36335#850574, @andrew.w.kaylor wrote:

> Can you revert the white space changes in the places you aren't otherwise modifying?  In general, you shouldn't make formatting changes outside of the parts of the file your patch is modifying.  It complicates the version control blame process without adding a lot of benefit.
>
> Also, your latest diffs seem not to have full file context (such as you get with the -x -U99999 switch with diff).  This isn't important for the current review, but it is something to keep in mind going forward.
>
> I really appreciate your work on this patch, and I hate to seem like I'm nit-picking a lot.  I just want to make sure we do things correctly.  Thanks!

Hi, Andrew, no problem at all. I will provide an updated full patch for this. Thanks a lot!

Repository:
  rL LLVM

https://reviews.llvm.org/D36335