[PATCH] D37075: Parse and print DIExpressions inline to ease IR and MIR testing

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks! Looks good (one comment inline).



================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-dce.ll:77
 ; CHECK-NEXT: call void @llvm.dbg.value(metadata %struct.entry* %queue,
-; CHECK-SAME:                           metadata ![[GEP1_EXPR:[0-9]+]])
+; CHECK-SAME:                           metadata !DIExpression(
+; CHECK-SAME:                              DW_OP_constu, 8,
----------------
I think it would be safer to have everything on one line.


================
Comment at: llvm/test/Transforms/InstCombine/debuginfo-dce.ll:95
+; CHECK-SAME:                           metadata !DIExpression(
+; CHECK-SAME:                               DW_OP_constu, 8, DW_OP_minus, DW_OP_stack_value))
   store %struct.entry** %1, %struct.entry*** %im_not_dead, align 8
----------------
same here


https://reviews.llvm.org/D37075