[PATCH] D37048: [lld] Update comments: parallel_for_each -> parallelForEach

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 12:04:38 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL311587: Update comments: parallel_for_each -> parallelForEach (authored by sbc).

Repository:
  rL LLVM

https://reviews.llvm.org/D37048

Files:
  lld/trunk/COFF/Writer.cpp
  lld/trunk/ELF/InputSection.cpp
  lld/trunk/ELF/Threads.h
  lld/trunk/ELF/Writer.cpp


Index: lld/trunk/COFF/Writer.cpp
===================================================================
--- lld/trunk/COFF/Writer.cpp
+++ lld/trunk/COFF/Writer.cpp
@@ -26,7 +26,6 @@
 #include "llvm/Support/FileOutputBuffer.h"
 #include "llvm/Support/Parallel.h"
 #include "llvm/Support/RandomNumberGenerator.h"
-#include "llvm/Support/raw_ostream.h"
 #include <algorithm>
 #include <cstdio>
 #include <map>
Index: lld/trunk/ELF/InputSection.cpp
===================================================================
--- lld/trunk/ELF/InputSection.cpp
+++ lld/trunk/ELF/InputSection.cpp
@@ -194,7 +194,7 @@
 }
 
 // Uncompress section contents. Note that this function is called
-// from parallel_for_each, so it must be thread-safe.
+// from parallelForEach, so it must be thread-safe.
 void InputSectionBase::uncompress() {
   Decompressor Dec = check(Decompressor::create(Name, toStringRef(Data),
                                                 Config->IsLE, Config->Is64));
@@ -920,7 +920,7 @@
 // that need to be linked. This is responsible to split section contents
 // into small chunks for further processing.
 //
-// Note that this function is called from parallel_for_each. This must be
+// Note that this function is called from parallelForEach. This must be
 // thread-safe (i.e. no memory allocation from the pools).
 void MergeInputSection::splitIntoPieces() {
   ArrayRef<uint8_t> Data = this->Data;
Index: lld/trunk/ELF/Writer.cpp
===================================================================
--- lld/trunk/ELF/Writer.cpp
+++ lld/trunk/ELF/Writer.cpp
@@ -23,7 +23,6 @@
 #include "llvm/ADT/StringMap.h"
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/FileOutputBuffer.h"
-#include "llvm/Support/raw_ostream.h"
 #include <climits>
 
 using namespace llvm;
Index: lld/trunk/ELF/Threads.h
===================================================================
--- lld/trunk/ELF/Threads.h
+++ lld/trunk/ELF/Threads.h
@@ -30,7 +30,7 @@
 //  - We have tens of millions of small strings when constructing a
 //    mergeable string section.
 //
-// For the cases such as the former, we can just use parallel_for_each
+// For the cases such as the former, we can just use parallelForEach
 // instead of std::for_each (or a plain for loop). Because tasks are
 // completely independent from each other, we can run them in parallel
 // without any coordination between them. That's very easy to understand


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37048.112418.patch
Type: text/x-patch
Size: 2419 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170823/54e37134/attachment.bin>


More information about the llvm-commits mailing list