[PATCH] D37065: Ensure standard pseudo instructions (TargetOpcode::*) are compatible with guessInstructionProperties=0

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: include/llvm/Target/Target.td:818
   let AsmString = "PHINODE";
+  let hasSideEffects = 1;
 }
----------------
asb wrote:
> qcolombet wrote:
> > I would default hasSideEffects to 0.
> It seemed odd to me too, but changing it would mean this patch does represent a functional change. I did try setting it to 0 before updating this patch, but found it results in a number of MachineVerifier errors as well as changes in test output.
Hmm, interesting, I wouldn't have expected this.
Could you elaborate on what are those?


https://reviews.llvm.org/D37065