[PATCH] D37073: [WebAssembly] FastISel : Lower constant calls as direct calls

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 10:03:32 PDT 2017


dschuff added a comment.

Are there any other constants/constexprs besides bitcast that we might encounter, that we should test? Looking at the constexprs, I don't see too much that looks likely. Maybe GEP? I guess  you can indirectly call a GlobalVariable, which ought to look the same as a local function pointer, maybe we should have a test for that too (presumably dag isel handles that too).
Also that this patch really does is just bail from fast-isel when the callee is a constant (which is fine), and that has the effect of causing calls of bitcasts to be lowered as direct calls.


https://reviews.llvm.org/D37073





More information about the llvm-commits mailing list