[PATCH] D37063: [LoopUnroll] Don't add metadata to unrolled remainder loop

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/DebugInfo/unrolled-loop-remainder.ll:6
+ at b = common local_unnamed_addr global i32 0, align 4, !dbg !0
+ at a = common local_unnamed_addr global i32* null, align 8, !dbg !6
+
----------------
Can you adda comment explaining what is being checked for in this test?


================
Comment at: test/DebugInfo/unrolled-loop-remainder.ll:52
+
+; CHECK-LABEL: d
+define void @d() local_unnamed_addr #1 !dbg !34 {
----------------
This looks dangerous. Doesn't this match almost every line?


================
Comment at: test/DebugInfo/unrolled-loop-remainder.ll:58
+
+attributes #0 = { norecurse nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { norecurse nounwind readnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
Can you strip out all non-essential attributes (i.e. usually everything in quotes)?


https://reviews.llvm.org/D37063