[PATCH] D37059: [ELF] - LTO: do not optimize away symbols accessed from linkerscript.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:632
       // Empty commands are allowed. Do nothing here.
-    } else if (SymbolAssignment *Assign = readProvideOrAssignment(Tok)) {
+    } else if (SymbolAssignment *Assign = readProvideOrAssignment(Tok, false)) {
       Cmd->Commands.push_back(Assign);
----------------
Why false?


================
Comment at: ELF/ScriptParser.cpp:705-707
+    if (Global && Tok != ".")
+      Script->Opt.ReferencedSymbols.push_back(Tok);
+    return Cmd;
----------------
This function doesn't seem like the best place to do this. Is readAssignment better, isn't it?


https://reviews.llvm.org/D37059