[PATCH] D23568: [RISCV 10/10] Add common fixups and relocations

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 23 04:51:25 PDT 2017


dylanmckay added a comment.

No problem, I remember it being quite hard to merge my own backend in-tree due to reviewers being scarce, thought I might as well help out :)

> I personally don't find that guideline very compelling for else if in cases where removing the else fails to reduce indentation

I can definitely understand that, at first I thought that the no `else` after `return` rule only applied to `else`, but I checked before this review and was surprised as well.

> The last patch update didn't have full context included - sorry for that.

No problem - that reminds me that I just made the same mistake on a patchset I just created!


https://reviews.llvm.org/D23568





More information about the llvm-commits mailing list