[PATCH] D37049: [Polly] Add various statistics.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 21:35:19 PDT 2017


grosser accepted this revision.
grosser added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Analysis/ScopDetection.cpp:1241
   int MaxLoopDepth = 1;
-  if (auto *TripCountC = dyn_cast<SCEVConstant>(TripCount))
-    if (TripCountC->getType()->getScalarSizeInBits() <= 64)
-      if (TripCountC->getValue()->getZExtValue() <= MinProfitableTrips)
-        NumLoops -= 1;
+  if (MinProfitableTrips > 0)
+    if (auto *TripCountC = dyn_cast<SCEVConstant>(TripCount))
----------------
Seems unrelated.


================
Comment at: lib/CodeGen/CodeGeneration.cpp:60
+STATISTIC(ScopsProcessed, "Number of SCoP processed");
+STATISTIC(CodegennedScops, "Number of successfully generated SCoPs");
+
----------------
typo


================
Comment at: lib/CodeGen/IslAst.cpp:88
+STATISTIC(NumOutermostParallel, "Number of outermost parallel for-loops");
+STATISTIC(NumRedunctionParallel, "Number of reduction-parallel for-loops");
+STATISTIC(NumExecutedInParellel, "Number of for-loops executed in parallel");
----------------
reduction


================
Comment at: lib/Transform/Simplify.cpp:122
 private:
+  /// The number of invocation of Simplify to determine which statistics to
+  /// update.
----------------
invocationS?


https://reviews.llvm.org/D37049





More information about the llvm-commits mailing list