[PATCH] D36086: [globalisel][tablegen] Add support for ImmLeaf without SDNodeXForm

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

Thanks for the updates, this looks really good now!



================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:143
+             "Expected G_CONSTANT");
+      assert(Predicate > 0 /*GIPFP_Invalid*/ && "Expected a valid predicate");
+      int64_t Value = 0;
----------------
Supernit: Predicate != GIPFP_Invalid seems more direct and readable...


https://reviews.llvm.org/D36086