[PATCH] D36990: [GISel]: Translate phi into generic G_PHI instruction

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Hi Aditya,

Looks mostly good to me.
Could you add a test case for the "verifier" like diagnostic you've added?

The RegisterBankInfo change seems strange to me. See inline comment.

Cheers,
-Quentin



================
Comment at: lib/Target/AArch64/AArch64RegisterBankInfo.cpp:423
   // or already have some operands assigned to banks.
-  if (!isPreISelGenericOpcode(Opc)) {
+  if (!isPreISelGenericOpcode(Opc) || Opc == TargetOpcode::G_PHI) {
     const RegisterBankInfo::InstructionMapping &Mapping =
----------------
We should need to do that.
Could you describe what happen if you don't?


Repository:
  rL LLVM

https://reviews.llvm.org/D36990