[PATCH] D36988: [InstCombine] fix and enhance udiv/urem narrowing

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineMulDivRem.cpp:1103
+  Constant *C;
+  if ((match(N, m_OneUse(m_ZExt(m_Value(X)))) && match(D, m_Constant(C))) ||
+      (match(D, m_OneUse(m_ZExt(m_Value(X)))) && match(N, m_Constant(C)))) {
----------------
craig.topper wrote:
> This is allowing arbitrary constant expressions through. Is that we want?
I don't see an issue with allowing ConstantExpr thru.


https://reviews.llvm.org/D36988