[PATCH] D36109: [CodeGen] Provide an advanced shrink-wrapping interface

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: lib/CodeGen/ShrinkWrapper.cpp:66
+  auto MarkAsUsed = [&](unsigned RegIdx, const MachineBasicBlock &MBB,
+                        bool isTerminator = false) {
+    unsigned MBBNum = MBB.getNumber();
----------------
Since the MarkAsUsed lambda is always called with 3 parameters, there is no need to specify a default value for this lambda parameter.


================
Comment at: lib/CodeGen/ShrinkWrapper.cpp:430
+  for (const MachineBasicBlock &MBB : MF) {
+    bool IsSCCLoop = false;
+    if (const SCCLoop *C = SI.getSCCLoopFor(MBB.getNumber())) {
----------------
IsSCCLoop is not used in this function.


https://reviews.llvm.org/D36109