[PATCH] D34497: [Power9] Exploit vinsertb instruction

[Kit Barton via Phabricator via llvm-commits]

kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

Aside from some minor changes to the comments, this LGTM.



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7898
+        continue;
+      // If CurrentElement is from V1 [0,15], then we the rest of the Mask to be
+      // from V2 [16,31] and vice versa.  Unless the 2nd operand is undefined,
----------------
... then we //set(?)// the rest of the Mask to be ...


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7900
+      // from V2 [16,31] and vice versa.  Unless the 2nd operand is undefined,
+      // in which we always assume we're always picking from the 1st operand.
+      int MaskOffset =
----------------
you can probably drop (at least) one of the //always// from this sentence. 


Repository:
  rL LLVM

https://reviews.llvm.org/D34497