[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:253
 
 void ScriptParser::addFile(StringRef S) {
+  if (S.startswith("/")) {
----------------
grimar wrote:
> Will it be better if I add following check here ?
> 
> ```
> if (ErrorCount)
>   return;
> ```
> 
> It still will be excessive check currently I believe (like I pointed in my previous comment), 
> but if code outside will change so that this function be called with `ErrorCount > 0`,
> such check will protect error reporting logic this patch introduces.
> 
> 
If that shouldn't happen, add it as an assert.


https://reviews.llvm.org/D35945