[PATCH] D36986: [ELF] Handle assignments outside SECTIONS command separately

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.h:78
+  // Whether the command is within SECTIONS command.
+  bool Sections = true;
 };
----------------
I think I'd name this `InSections`.

But do you actually need this? This is I believe virtually a flag indicating whether an element is a direct child of the top element or not. But we can distinguish BaseCommands enclosed in an OutputSections from BaseCommands that are top-level elements, no?


================
Comment at: ELF/Writer.cpp:227
 
+  Script->processOutsideSectionsCommands();
+
----------------
Add a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D36986