[llvm] r311466 - [Debug info] Add new DbgValues after looping over DAG

[Jonas Devlieghere via llvm-commits]

Author: jdevlieghere
Date: Tue Aug 22 09:28:07 2017
New Revision: 311466

URL: http://llvm.org/viewvc/llvm-project?rev=311466&view=rev
Log:
[Debug info] Add new DbgValues after looping over DAG

I was contacted by Jesper Antonsson from Ericsson who ran into problems
with r311181 in their test suites with for an out-of-tree target.
Because of the latter I don't have a reproducer, but we definitely don't
want to modify the data structure on which we are iterating inside the
loop.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp?rev=311466&r1=311465&r2=311466&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeTypes.cpp Tue Aug 22 09:28:07 2017
@@ -834,6 +834,7 @@ static void transferDbgValues(SelectionD
   SDNode *ToNode = To.getNode();
   assert(FromNode != ToNode);
 
+  SmallVector<SDDbgValue *, 2> ClonedDVs;
   for (SDDbgValue *Dbg : DAG.GetDbgValues(FromNode)) {
     if (Dbg->getKind() != SDDbgValue::SDNODE)
       break;
@@ -846,12 +847,15 @@ static void transferDbgValues(SelectionD
         DAG.getDbgValue(Var, Fragment, ToNode, To.getResNo(), Dbg->isIndirect(),
                         Dbg->getDebugLoc(), Dbg->getOrder());
     Dbg->setIsInvalidated();
-    DAG.AddDbgValue(Clone, ToNode, false);
+    ClonedDVs.push_back(Clone);
 
     // Add the expression to the metadata graph so isn't lost in MIR dumps.
     const Module *M = DAG.getMachineFunction().getMMI().getModule();
     M->getNamedMetadata("llvm.dbg.mir")->addOperand(Fragment);
   }
+
+  for (SDDbgValue *Dbg : ClonedDVs)
+    DAG.AddDbgValue(Dbg, ToNode, false);
 }
 
 void DAGTypeLegalizer::SetExpandedInteger(SDValue Op, SDValue Lo,