[PATCH] D36499: If --dynamic-list is given, only those symbols are preemptible

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 22 09:28:04 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Since Rafael is on vacation, I'll submit this patch with the following fixes.



================
Comment at: ELF/ScriptParser.cpp:182-183
+  expect(";");
   if (!atEOF())
     setError("EOF expected, but got " + next());
+  if (!Locals.empty())
----------------
You want to `return` here.


================
Comment at: ELF/ScriptParser.cpp:185
+  if (!Locals.empty())
+    setError("\"local:\" scope not supported in --dynamic-list" + next());
+  for (SymbolVersion V : Globals)
----------------
`+ next()` doesn't seem to make sense, so remove.


https://reviews.llvm.org/D36499





More information about the llvm-commits mailing list