[PATCH] D23568: [RISCV 10/10] Add common fixups and relocations

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVELFObjectWriter.cpp:42
+  // Determine the type of the relocation
+  switch ((unsigned)Fixup.getKind()) {
+  default:
----------------
dylanmckay wrote:
> Do you need this cast here? You save a similar switch in `RISCVAsmBackend` without one
The cast is needed to avoid a warning "case value not in enumerated type 'llvm::MCFixupKind'".


https://reviews.llvm.org/D23568