[PATCH] D36984: [SelectionDAG] Add getNode debug messages

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

Hi Sjoerd,

Thanks for doing this, I think it will be really useful. Just a couple of small inline comments from me.

cheers,
sam



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:90
 
+#define DEBUG_TYPE "SelectionDAG"
+
----------------
nit, debug names are usually lower case.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4734
+    if (SDNode *E = FindNodeOrInsertPos(ID, DL, IP)) {
+      SDValue V = SDValue(E, 0);
+      NewSDValueDbgMsg(V, "Creating new node: ");
----------------
This isn't actually creating a new node though, right?


https://reviews.llvm.org/D36984