[PATCH] D36255: Integrate manifest merging library into LLD.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:377
+  // Create the default manifest file as a temporary file.
+  TemporaryFile Default("defaultxml", "manifest");
+  std::error_code EC;
----------------
zturner wrote:
> If we're not on Windows we should emit a warning that the manifest file was ignored since mt will not be available.
I actually think we should continue to throw an error,  because it is never valid to ignore the manifest when producing  the executable.


https://reviews.llvm.org/D36255