[PATCH] D36680: [test-suite] Adding Pathfinder Benchmark

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

A couple of things I'll fix while committing...



================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/main.c:81
+    Configuration *config = Configuration_new();
+    char c;
+    int cFlag = 0; // Why did I make these ints instead of bool? JBR - 10/25/13
----------------
This must be `signed char` or else it can never be equal to -1 below on platforms, such as PowerPC, where char is unsigned.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/searchAlgorithms.c:452
+    tick = currentTime();
+    fprintf ( stderr, "Immediately before parallel\n" );
+
----------------
Likewise, having this go to stderr can lead to a confusing output ordering.


================
Comment at: MultiSource/Benchmarks/DOE-ProxyApps-C/Pathfinder/searchAlgorithms.c:545
+    tick = currentTime();
+    fprintf(stderr, "Immediately before parallel\n" );
+
----------------
Having this go to stderr can lead to confused ordering with the other outputs.


https://reviews.llvm.org/D36680