[PATCH] D36255: Integrate manifest merging library into LLD.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 17:27:00 PDT 2017


ecbeckmann updated this revision to Diff 112094.
ecbeckmann added a comment.

Instead of returning nullptr when libxml is not installed, it returns an error
which is more descriptive, and also doesn't require code outside the manifest
library to understand the cases for returning error/nullptr.


https://reviews.llvm.org/D36255

Files:
  lld/COFF/CMakeLists.txt
  lld/COFF/DriverUtils.cpp
  lld/test/COFF/manifestinput.test
  lld/test/lit.cfg
  lld/test/lit.site.cfg.in
  llvm/include/llvm/WindowsManifest/WindowsManifestMerger.h
  llvm/lib/WindowsManifest/WindowsManifestMerger.cpp
  llvm/test/tools/llvm-mt/Inputs/assembly_identity.manifest
  llvm/test/tools/llvm-mt/Inputs/compatibility.manifest
  llvm/test/tools/llvm-mt/Inputs/expected_big.manifest
  llvm/test/tools/llvm-mt/Inputs/test_manifest.manifest
  llvm/test/tools/llvm-mt/Inputs/trust_and_identity.manifest
  llvm/test/tools/llvm-mt/Inputs/trust_info.manifest
  llvm/test/tools/llvm-mt/Inputs/windows_settings.manifest
  llvm/test/tools/llvm-mt/big_merge.test
  llvm/test/tools/llvm-mt/simple_merge.test
  llvm/test/tools/llvm-mt/single_file.test
  llvm/tools/llvm-mt/Opts.td
  llvm/tools/llvm-mt/llvm-mt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36255.112094.patch
Type: text/x-patch
Size: 51801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170822/b1af119c/attachment.bin>


More information about the llvm-commits mailing list