[PATCH] D29935: [RISCV 13/n] Codegen for conditional branches

[Dylan McKay via Phabricator via llvm-commits]

dylanmckay added a comment.

Are there any tests for the stack slot loading/storing? If there are some in a later patch, that's fine too.



================
Comment at: lib/Target/RISCV/RISCVRegisterInfo.cpp:78
+  } else {
+    report_fatal_error(
+        "Frame offsets outside of the signed 12-bit range not supported");
----------------
I think it makes more sense for `report_fatal_error` to live outside of the `else` entirely, and then the `else` can be removed as well.


https://reviews.llvm.org/D29935