[PATCH] D36958: [ELF] Remove dependency on hexdump from lit tests

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 21 06:57:54 PDT 2017


jhenderson created this revision.
Herald added a subscriber: emaste.

hexdump is not part of the GNU coreutils, and so is not required to be able to build and test LLVM, according to the documentation. This change removes the dependency on hexdump from a lit test.


https://reviews.llvm.org/D36958

Files:
  test/ELF/fill-trap.s


Index: test/ELF/fill-trap.s
===================================================================
--- test/ELF/fill-trap.s
+++ test/ELF/fill-trap.s
@@ -3,7 +3,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
 # RUN: ld.lld %t -o %t2
 # RUN: llvm-readobj -program-headers %t2 | FileCheck %s
-# RUN: hexdump -v -s 0x0001ff0 -x %t2 | FileCheck %s -check-prefix=FILL
+# RUN: od -Ax -x -N16 -j0x1ff0 %t2 | FileCheck %s -check-prefix=FILL
 
 # CHECK: ProgramHeader {
 # CHECK:   Type: PT_LOAD
@@ -17,8 +17,8 @@
 # CHECK-NEXT:     PF_X
 # CHECK-NEXT:   ]
 
-## Check that executable page is filled with traps at it's end.
-# FILL: 0001ff0 cccc cccc cccc cccc cccc cccc cccc cccc
+## Check that executable page is filled with traps at its end.
+# FILL: 001ff0 cccc cccc cccc cccc cccc cccc cccc cccc
 
 .globl _start
 _start:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36958.111966.patch
Type: text/x-patch
Size: 858 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170821/a0faf034/attachment.bin>


More information about the llvm-commits mailing list