[PATCH] D36901: [Coverage] Add an expensive test for the segment builder

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 20 22:34:18 PDT 2017


ikudrin added a comment.

LGTM



================
Comment at: unittests/ProfileData/CoverageMappingTest.cpp:612
+    void generate(unsigned StartingIdx) {
+      for (unsigned I = StartingIdx; I < N; ++I) {
+        C.push_back(I);
----------------
Strictly speaking, it should be something like `I < N - R + C.size() + 1`, but taking into account the volume of N it doesn't matter.


https://reviews.llvm.org/D36901





More information about the llvm-commits mailing list