[PATCH] D31870: [XRay][tools] Fix an accounting bug in llvm-xray account

[Dean Michael Berris via Phabricator via llvm-commits]

dberris marked 2 inline comments as done.
dberris added inline comments.


================
Comment at: test/tools/llvm-xray/X86/account-empty-stack-error.yaml:15-16
+# which should be handled with grace (i.e. we treat it as an error, but since
+# the llvm-xray account tool has an option to keep going, gives the user a
+# chance to retry).
+  - { type: 0, func-id: 1, cpu: 1, thread: 1, kind: function-exit, tsc: 10000}
----------------
dberris wrote:
> dblaikie wrote:
> > Is the "keep going" functionality sufficiently tested? (Does this new error path present an interesting/new case of "keep going" that's worth testing separately - or is the functionality sufficiently generic that the existing testing covers enough here)
> We have a dedicated test that uses -k for account. This particular case isn't so interesting, because we're not attempting to recover or handle it (yet). In the future we may want to indicate in the accounting how many records we've discarded, how many we've deduced tail calls for, etc. -- but that's not so important at the moment than not crashing when we have this situation.
I added a test for the keep-going path as well, making sure it works in this path as well.


https://reviews.llvm.org/D31870