[PATCH] D36930: [ARM] Factorize the calculation of WhichResult in isV*Mask. NFC.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 19 13:18:59 PDT 2017


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, I think it's a nice simplification and was already discussed in https://reviews.llvm.org/D36899. Please check the formatting before committing.



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:5803
 
+static unsigned SelectPairHalf(unsigned Elements, ArrayRef<int> Mask, unsigned Index) {
+  if (Mask.size() == Elements * 2)
----------------
Line too long?


https://reviews.llvm.org/D36930





More information about the llvm-commits mailing list