[PATCH] D36906: Keep Optimization Remark Yaml in NewPM

Adam Nemet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 22:24:46 PDT 2017


anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: tools/opt/NewPMDriver.cpp:173
                            tool_output_file *ThinLTOLinkOut,
-                           StringRef PassPipeline, OutputKind OK,
-                           VerifierKind VK,
+                           tool_output_file *YamlFile, StringRef PassPipeline,
+                           OutputKind OK, VerifierKind VK,
----------------
I know that I called this YamlFile in opt.cpp but that's really unfortunate in retrospect.   Can you please call this something like OptRemarksFile or something?


https://reviews.llvm.org/D36906





More information about the llvm-commits mailing list