[PATCH] D36858: [x86] Teach the cmov converter to aggressively convert cmovs with memory operands into control flow.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 18 18:33:22 PDT 2017


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with the one nit.



================
Comment at: test/CodeGen/X86/x86-cmov-converter.ll:414
+; Test that we don't convert a group of cmovs with conflicting directions of
+;loads.
+define i32 @test_cmov_memoperand_conflicting_dir(i32 %a, i32 %b, i32 %x, i32* %y1.ptr, i32* %y2.ptr) #0 {
----------------
nit, space before "loads"


https://reviews.llvm.org/D36858





More information about the llvm-commits mailing list