[compiler-rt] r310973 - Quickfix to the refactoring commit: typo in the link flags variable

[Simon Dardis via llvm-commits]

Testing in progress, will be a while before I get results as a fresh build is needed.

Thanks,
Simon
________________________________________
From: ekarpenkov at apple.com [ekarpenkov at apple.com]
Sent: 18 August 2017 18:16
To: Simon Dardis
Cc: llvm-commits at lists.llvm.org
Subject: Re: [compiler-rt] r310973 - Quickfix to the refactoring commit: typo in the link flags variable

Hi Simon,

Could you test https://reviews.llvm.org/D36881 ?
> On Aug 18, 2017, at 6:25 AM, Simon Dardis <Simon.Dardis at imgtec.com> wrote:
>
>
> Hi George,
>
> This change + r310971 appears to have broken building the test objects for the sanitizers
> for mips: http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/4941
>
> The linker appears to be trying to link mips & mips64 objects together.
>
> Can you investigate or revert?
>
> Thanks,
> Simon
>> -----Original Message-----
>> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
>> Of George Karpenkov via llvm-commits
>> Sent: 16 August 2017 00:23
>> To: llvm-commits at lists.llvm.org
>> Subject: [compiler-rt] r310973 - Quickfix to the refactoring commit: typo in
>> the link flags variable
>>
>> Author: george.karpenkov
>> Date: Tue Aug 15 16:22:52 2017
>> New Revision: 310973
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=310973&view=rev
>> Log:
>> Quickfix to the refactoring commit: typo in the link flags variable name.
>>
>> Modified:
>>    compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake
>>
>> Modified: compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake
>> URL: http://llvm.org/viewvc/llvm-project/compiler-
>> rt/trunk/cmake/Modules/AddCompilerRT.cmake?rev=310973&r1=310972&r
>> 2=310973&view=diff
>> ==========================================================
>> ====================
>> --- compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake (original)
>> +++ compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake Tue Aug 15
>> +++ 16:22:52 2017
>> @@ -324,7 +324,7 @@ function(generate_compiler_rt_tests test
>>     SUBDIR ${TEST_SUBDIR}
>>     OBJECTS ${${test_objects}}
>>     DEPS ${TEST_DEPS}
>> -    LINK_FLAGS ${TARGET_LINK_FLAGS}
>> +    LINK_FLAGS ${TEST_LINK_FLAGS}
>>     )
>>   set("${test_objects}" "${${test_objects}}" PARENT_SCOPE)
>> endfunction()
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits