[PATCH] D36858: [x86] Teach the cmov converter to aggressively convert cmovs with memory operands into control flow.

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added a comment.

In https://reviews.llvm.org/D36858#845606, @chandlerc wrote:

> While I'm writing the fix, and since it is already late in your TZ -- any other concerns before I land this?


No concerns, the direction looks just fine.
We only need to make sure the functionality is not broken.

Also, I just got the results from running internal benchmarks, and it seems that this optimization did not affect most of the workloads, and those that had code change, the performance was not affected as well!
So, I do not see a reason why not to continue with this improvement.


https://reviews.llvm.org/D36858