[PATCH] D36766: Reorder operands with provided Opcode
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 18 06:50:47 PDT 2017
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
Thanks for reducing this, LGTM with one minor. Also, as this is just a refactor at this point (make sure you rephrase the commit summary accordingly btw) you can probably drop the test case as its not doing anything any more.
================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:2475
+ VLeft = I->getOperand(0);
+ VRight = I->getOperand(1);
if (!isa<Instruction>(VRight) && isa<Instruction>(VLeft))
----------------
Tidyup (although I realise it increases the diff vs D28907):
```
Value *VLeft = I->getOperand(0);
Value *VRight = I->getOperand(1);
```
https://reviews.llvm.org/D36766
More information about the llvm-commits
mailing list