[PATCH] D36816: [XRay][compiler-rt] Support sled versioning for custom event sleds

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 22:24:17 PDT 2017


dberris added inline comments.


================
Comment at: test/xray/TestCases/Linux/custom-event-logging.cc:5
 // RUN: XRAY_OPTIONS="patch_premain=false verbosity=1 xray_naive_log=false xray_logfile_base=custom-event-logging.xray-" %run %t 2>&1 | FileCheck %s
+// RUN: %clangxx_xray -std=c++11 -fpic -fpie %s -o %t
+// RUN: XRAY_OPTIONS="patch_premain=false verbosity=1 xray_naive_log=false xray_logfile_base=custom-event-logging.xray-" %run %t 2>&1 | FileCheck %s
----------------
kpw wrote:
> Is the position independent code stuff related to the sled change or just along for the ride?
Ah, right -- it's along for the ride, because the dependent change has to work with PIC and PIE changes.


https://reviews.llvm.org/D36816





More information about the llvm-commits mailing list