[PATCH] D36717: [test-suite] Add SPEC CPU 2017

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

One more remark: The 'ref' dataset of 638.imagick_s on all the computers I tried on took between 2 and 3 hours. Submitted results to SPEC <https://www.spec.org/cpu2017/results/res2017q2/cpu2017-20161026-00017.html> are in a similar range. Unfortunately `timeit.py` has a 7200 seconds (2 hours) limit hardcoded (for `--limit-cpu` __and__ `--timeout`). I had to remove that limit to be able to have a successful run.

Can we make the limit configurable or set higher?



================
Comment at: External/SPEC/CFP2017rate/519.lbm_r/CMakeLists.txt:9
+
+link_libraries(-lm)
+
----------------
MatzeB wrote:
> Most parts of the test-suite use `list(APPEND LDFLAGS -lm)` for this (that's not better but maybe more consistent)
I assumed that CPPFLAGS, CFLAGS and LDFLAGS are there only from the automatic upgrade from the Makefiles. The SPEC2006 also mostly use include_directories/add_definitions instead of C(PP)FLAGS. I stayed consistent with that.

The handling of `LDFLAGS` in `llvm_test_executable` is mmmh... ugly. I also need the flags applied on the image_validator and ldecod from x264. `link_libraries` was practical here because it also applied to these executables.


https://reviews.llvm.org/D36717