[llvm] r309310 - Un-revert "Teach the CMake build system to run lit's test suite. These can be run"

[Yung, Douglas via llvm-commits]

I am fairly certain that the test which is timing out is the "lit :: shtest.py" test that I mentioned previously. If you look for each of the tests in the lit test directory, you will see them all in the output except for that one. I cannot reproduce the timeout locally though, so I'm not sure why it is getting stuck on the build bot.

Douglas Yung

> -----Original Message-----
> From: Victor Leschuk [mailto:vleschuk at accesssoftek.com]
> Sent: Thursday, August 17, 2017 12:16
> To: Yung, Douglas; Brian Gesiak
> Cc: llvm-commits at lists.llvm.org
> Subject: Re: [llvm] r309310 - Un-revert "Teach the CMake build system to run
> lit's test suite. These can be run"
> 
> Yep, I agree. I will continue analyzing procmon log for possible causes
> (already reverse-merged that change back).
> 
> 
> On 08/17/2017 10:14 PM, Yung, Douglas wrote:
> > I don't think that was the problem, at least the PS4 Windows bot is still
> failing with a timeout...
> >
> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windo
> > ws10pro-fast/builds/11572
> >
> > Douglas Yung
> >
> >> -----Original Message-----
> >> From: Victor Leschuk [mailto:vleschuk at accesssoftek.com]
> >> Sent: Thursday, August 17, 2017 8:11
> >> To: Yung, Douglas; Brian Gesiak
> >> Cc: llvm-commits at lists.llvm.org
> >> Subject: Re: [llvm] r309310 - Un-revert "Teach the CMake build system
> >> to run lit's test suite. These can be run"
> >>
> >> I've marked this test as unsupported for now. Let's see...
> >>
> >>
> >> On 08/17/2017 05:59 PM, Victor Leschuk via llvm-commits wrote:
> >>> Looks like the failing test is Verifier/invalid-eh.ll . The problem
> >>> with it is that the first sed fails:
> >>>
> >>> sed -e s/.T11://
> >>> C:\ps4-buildslave2\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\
> >>> ll
> >>> vm.src\test\Verifier\invalid-eh.ll
> >>>
> >>> with BUFFER_OVERFLOW.
> >>>
> >>> I'll try to reproduce it on my machine.
> >>>
> >>>
> >>> On 08/17/2017 03:52 PM, Victor Leschuk via llvm-commits wrote:
> >>>> Hello all, I've managed to collect process monitor logs for this,
> >>>> analyzing them now.
> >>>>
> >>>>
> >>>> On 08/12/2017 01:57 AM, Yung, Douglas wrote:
> >>>>> Hi Brian,
> >>>>>
> >>>>> I don't know if you made any progress looking into this, but I
> >>>>> think the test that appears to be timing out is "lit :: shtest-
> format.py".
> >>>>> At least the PS4 Windows bot does not seem to have an entry in the
> >>>>> test logs for that test (and one test timed out). I looked through
> >>>>> the logs of this test run:
> >>>>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-w
> >>>>> in
> >>>>> dows10pro-fast/builds/11501
> >>>>>
> >>>>> Douglas Yung
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Brian Gesiak [mailto:modocache at gmail.com]
> >>>>>> Sent: Tuesday, August 08, 2017 17:57
> >>>>>> To: Victor Leschuk
> >>>>>> Cc: Yung, Douglas; llvm-commits at lists.llvm.org
> >>>>>> Subject: Re: [llvm] r309310 - Un-revert "Teach the CMake build
> >>>>>> system to run lit's test suite. These can be run"
> >>>>>>
> >>>>>> Hmm, it looks like a timeout of some kind...? If we could narrow
> >>>>>> down which test is timing out, we could simply mark that test as
> >>>>>> unsupported on Windows, as a short term solution. I'll try to
> >>>>>> look into
> >> this tomorrow evening.
> >>>>>> - Brian
> >>>>>>
> >>>>>> On Tue, Aug 8, 2017 at 1:14 AM, Victor Leschuk
> >>>>>> <vleschuk at accesssoftek.com>
> >>>>>> wrote:
> >>>>>>> Hello, thanks for the commit, unfortunately it didn't fix the
> >>>>>>> problem on the buildbot (see build logs at
> >>>>>>> http://lab.llvm.org:8011/buildslaves/ps4-buildslave2). Any ideas
> >>>>>>> what can we do to solve this?
> >>>>>>>
> >>>>>>>
> >>>>>>> On 08/02/2017 09:31 AM, Brian Gesiak wrote:
> >>>>>>>> Victor, Douglas,
> >>>>>>>>
> >>>>>>>> I've verified https://reviews.llvm.org/D36212 fixes the issue
> >>>>>>>> for me; builds on my macOS and Windows hosts succeed. Please
> >>>>>>>> take a look and let me know if it fixes the issues on your buildbot.
> >>>>>>>>
> >>>>>>>> Thanks for your help debugging, and your patience!
> >>>>>>>>
> >>>>>>>> - Brian
> >>>>>>> --
> >>>>>>> Best Regards,
> >>>>>>>
> >>>>>>> Victor Leschuk | Software Engineer |Access Softek
> >>>>>>>
> >> --
> >> Best Regards,
> >>
> >> Victor Leschuk | Software Engineer |Access Softek
> 
> --
> Best Regards,
> 
> Victor Leschuk | Software Engineer |Access Softek