[PATCH] D36812: Add support for writing 64-bit symbol tables for archives when offsets become too large for 32-bit

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 11:29:32 PDT 2017


phosek added inline comments.


================
Comment at: lib/Object/ArchiveWriter.cpp:152
 
+static void print64(raw_ostream &Out, object::Archive::Kind Kind,
+                    uint64_t Val) {
----------------
This function is exactly the same as print32 except for the `Val` type, couldn't you use a single templated function and avoid the `printNBits` altogether?


Repository:
  rL LLVM

https://reviews.llvm.org/D36812





More information about the llvm-commits mailing list