[PATCH] D36381: [MISched] Add enableMachineScheduler function that checks enable-misched.

[Florian Hahn via Phabricator via llvm-commits]

fhahn abandoned this revision.
fhahn added a comment.

In https://reviews.llvm.org/D36381#834280, @atrick wrote:

> It sounds to me like you want a "MI-Sched Mode" convenience flag that does more than what it claims to do at face value, rather than needing to specify all the individual flags for SelectionDAG heuristic, enabling MI-Sched, coalescing heuristic. I'm not going to nit pick on the flag names because I don't have any stake it in. But I think you need to discuss this on llvm-dev and argue it out taking into consideration all of the goals:
>
> - avoid confusions between the subtarget enableMachineScheduling() API and -mi-sched flag, which seems to have been a problem for you.
> - provide "enable/disable" flags that don't do any magic beyond literally enabling or disabled the named pass, (that kind of magic been huge source of confusion in that past when it comes to triaging bugs and gathering performance data)
> - unit tests should explicitly spell out precisely the passes/functionality that it depends on rather than relying on some umbrella "mode" that can change over time.


Agreed, I was just confused by the current behavior I think, but I don't think it's worth to change anything now.


https://reviews.llvm.org/D36381