[PATCH] D36138: [ELF] - Don't segfault when accessing location counter inside MEMORY command.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 17 01:01:23 PDT 2017


grimar added inline comments.


================
Comment at: test/ELF/linkerscript/memory-err.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
----------------
grimar wrote:
> ruiu wrote:
> > Rename memory-error.s (you don't need to save two characters in filename.)
> Ok, though we have many tests with both ways of naming atm.
Ah and we already have `memory-err.s` one committed. 
I'll leave name unchanged for commit. 

Should we rename all `*-err.s` to `*-error.s` at once then ?


https://reviews.llvm.org/D36138





More information about the llvm-commits mailing list