[llvm] r311014 - [BDCE] Don't check demanded bits on unsized types

[Hal Finkel via llvm-commits]

Author: hfinkel
Date: Wed Aug 16 09:09:22 2017
New Revision: 311014

URL: http://llvm.org/viewvc/llvm-project?rev=311014&view=rev
Log:
[BDCE] Don't check demanded bits on unsized types

To clear assumptions that are potentially invalid after trivialization, we need
to walk the use/def chain. Normally, the only way to reach an instruction with
an unsized type is via an instruction that has side effects (or otherwise will
demand its input bits). That would stop the walk. However, if we have a
readnone function that returns an unsized type (e.g., void), we must avoid
asking for the demanded bits of the function call's return value. A
void-returning readnone function is always dead (and so we can stop walking the
use/def chain here), but the check is necessary to avoid asserting.

Fixes PR34211.

Added:
    llvm/trunk/test/Transforms/BDCE/dead-void-ro.ll
Modified:
    llvm/trunk/lib/Transforms/Scalar/BDCE.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/BDCE.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/BDCE.cpp?rev=311014&r1=311013&r2=311014&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/BDCE.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/BDCE.cpp Wed Aug 16 09:09:22 2017
@@ -48,8 +48,18 @@ static void clearAssumptionsOfUsers(Inst
     // If all bits of a user are demanded, then we know that nothing below that
     // in the def-use chain needs to be changed.
     auto *J = dyn_cast<Instruction>(JU);
-    if (J && !DB.getDemandedBits(J).isAllOnesValue())
+    if (J && J->getType()->isSized() &&
+        !DB.getDemandedBits(J).isAllOnesValue())
       WorkList.push_back(J);
+
+    // Note that we need to check for unsized types above before asking for
+    // demanded bits. Normally, the only way to reach an instruction with an
+    // unsized type is via an instruction that has side effects (or otherwise
+    // will demand its input bits). However, if we have a readnone function
+    // that returns an unsized type (e.g., void), we must avoid asking for the
+    // demanded bits of the function call's return value. A void-returning
+    // readnone function is always dead (and so we can stop walking the use/def
+    // chain here), but the check is necessary to avoid asserting.
   }
 
   // DFS through subsequent users while tracking visits to avoid cycles.
@@ -70,7 +80,8 @@ static void clearAssumptionsOfUsers(Inst
       // If all bits of a user are demanded, then we know that nothing below
       // that in the def-use chain needs to be changed.
       auto *K = dyn_cast<Instruction>(KU);
-      if (K && !Visited.count(K) && !DB.getDemandedBits(K).isAllOnesValue())
+      if (K && !Visited.count(K) && K->getType()->isSized() &&
+          !DB.getDemandedBits(K).isAllOnesValue())
         WorkList.push_back(K);
     }
   }

Added: llvm/trunk/test/Transforms/BDCE/dead-void-ro.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/BDCE/dead-void-ro.ll?rev=311014&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/BDCE/dead-void-ro.ll (added)
+++ llvm/trunk/test/Transforms/BDCE/dead-void-ro.ll Wed Aug 16 09:09:22 2017
@@ -0,0 +1,18 @@
+; RUN: opt -S -bdce < %s | FileCheck %s
+
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @PR34211(i16* %p) {
+; CHECK-LABEL: @PR34211
+  %not_demanded_but_not_dead = load volatile i16, i16* %p
+  call void @no_side_effects_so_dead(i16 %not_demanded_but_not_dead)
+  ret void
+
+; CHECK: %not_demanded_but_not_dead = load volatile i16, i16* %p
+; CHECK-NEXT: ret void
+}
+
+declare void @no_side_effects_so_dead(i16) #0
+
+attributes #0 = { nounwind readnone }
+