[PATCH] D36787: [ARM] Fix and reenable arm-promote-constant.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 16 03:47:33 PDT 2017


dmgreen added a comment.

This involves adding a new ARMConstantPoolIndexAddress so as to point the newly created constant entry at the symbol name of the other. The reference counting can get a bit gnarly, and the testing here could do with being improved. It passes the various bootstraps I throw at it, but there might well be some combination of options/conditions that make things fail. Any ideas of better ways to test this?

So it seems like a workable solution, but does make constant island pass slightly more complex. What do people think?


https://reviews.llvm.org/D36787





More information about the llvm-commits mailing list