[PATCH] D36729: Fix two (three) more issues with unchecked Error.
Lang Hames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 17:53:55 PDT 2017
lhames added inline comments.
================
Comment at: include/llvm/ExecutionEngine/Orc/OrcRemoteTargetClient.h:171-174
auto Err = Client.deregisterEHFrames(Frame.Addr, Frame.Size);
// FIXME: Add error poll.
assert(!Err && "Failed to register remote EH frames.");
+ llvm::cantFail(std::move(Err));
----------------
Since we're not using the error we can avoid naming it at all and just have:
//FIXME: Add error poll.
cantFail(Client.deregisterEHFrames(Frame.Addr, Frame.Size));
https://reviews.llvm.org/D36729
More information about the llvm-commits
mailing list