[PATCH] D36757: Add C++17 aligned new/delete interceptors to standalone lsan
Aleksey Shlyapnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 15 15:50:26 PDT 2017
alekseyshl added inline comments.
================
Comment at: lib/lsan/lsan_interceptors.cc:305
{ OPERATOR_DELETE_BODY; }
#endif // !SANITIZER_MAC
----------------
fjricci wrote:
> fjricci wrote:
> > alekseyshl wrote:
> > > fjricci wrote:
> > > > alekseyshl wrote:
> > > > > Don't we need to intercept by mangled names here too?
> > > > ASan currently does not. Shouldn't be hard to add the mangled name interception for both ASan and LSan in a second patch (unless you'd rather have it all here).
> > > Why not, let's add them in this patch.
> > Sounds good.
> I don't think we can add these on macOS until they're added in libc++, otherwise we get undefined symbol errors.
OK then, let's do it later.
https://reviews.llvm.org/D36757
More information about the llvm-commits
mailing list