[PATCH] D36762: [Builtins][ARM] Force ARM state for bswap for pre-ARMv6

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 15 12:00:34 PDT 2017


efriedma added inline comments.


================
Comment at: lib/builtins/arm/bswapdi2.S:26
     // r2 = rev(r0)
+    .arm
     eor r2, r0, r0, ror #16
----------------
This doesn't do the right thing: the function symbol will still be decorated with .thumb_func, so this will try to execute ARM instructions in Thumb mode (and probably crash).


https://reviews.llvm.org/D36762





More information about the llvm-commits mailing list