[PATCH] D36711: [X86] Combining CMOVs with [ANY, SIGN, ZERO]_EXTEND for cases where CMOV has constant arguments

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/CodeGen/X86/cmov-promotion.ll:1-2
+; RUN: llc < %s -mtriple=x86_64-unknown-linux | FileCheck %s --check-prefix=CHECK
+; RUN: llc < %s -mtriple=i386-intel-elfiamcu  | FileCheck %s --check-prefix=MCU
+
----------------
1. Please add this file to trunk with the utils script auto-generated baseline checks, so we just see the diffs in this patch.
2. It's not clear to me what the 2nd run is showing. That target has cmov, but it gets converted to test+branch later?
3. Assuming the 2nd run is necessary, why are there no MCU checks for the 2nd test?
4. Should there be an spromotion_16_to_64 for completeness?


https://reviews.llvm.org/D36711